Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use Failure to programmatically cancel Ask #5187

Merged
merged 2 commits into from Aug 10, 2021
Merged

use Failure to programmatically cancel Ask #5187

merged 2 commits into from Aug 10, 2021

Conversation

Aaronontheweb
Copy link
Member

@Aaronontheweb Aaronontheweb commented Aug 9, 2021 •
edited

close #3091 - part of the Ask API that's never been fully implemented.

Arkatufus
Arkatufus approved these changes Aug 9, 2021
View reviewed changes
Copy link
Contributor

@Arkatufus Arkatufus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Arkatufus Arkatufus enabled auto-merge (squash) August 9, 2021 23:49
@Aaronontheweb Aaronontheweb merged commit 6b4a913 into akkadotnet:dev Aug 10, 2021
@Aaronontheweb Aaronontheweb deleted the ask-failure branch August 10, 2021 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arkatufus Arkatufus Arkatufus approved these changes

Assignees
No one assigned
Labels
akka-actor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ask does not set exception on the underlying TaskCompletionSource when callee responds with Failure
2 participants
@Aaronontheweb @Arkatufus