Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSet elements needs to be sorted during serialization #5093

Conversation

Arkatufus
Copy link
Contributor

Just like ORSet, GSet elements need to be sorted during serialization so that the digest of any same GSets with the same elements with different element positioning will always be the same.

@Aaronontheweb Aaronontheweb added akka-ddata akka-ddata-durable LMDB implementation for persisting durable data labels Jun 15, 2021
@Aaronontheweb Aaronontheweb added this to the 1.4.21 milestone Jun 15, 2021
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -7,6 +7,11 @@ namespace Akka.DistributedData.Serialization
{
internal class OtherMessageComparer : IComparer<OtherMessage>
{
public static OtherMessageComparer Instance { get; } = new OtherMessageComparer();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea

@Aaronontheweb Aaronontheweb merged commit 0210e21 into akkadotnet:dev Jun 15, 2021
@Arkatufus Arkatufus deleted the Fix_DData_GSet_elements_need_to_be_sorted branch February 27, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
akka-ddata akka-ddata-durable LMDB implementation for persisting durable data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants