Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AK1000 Must close over Sender and Self when accessed inside a lambda argument body #71

Closed
Arkatufus opened this issue Feb 26, 2024 · 3 comments · Fixed by #87
Closed

AK1000 Must close over Sender and Self when accessed inside a lambda argument body #71

Arkatufus opened this issue Feb 26, 2024 · 3 comments · Fixed by #87

Comments

@Arkatufus
Copy link
Contributor

Arkatufus commented Feb 26, 2024 •
edited

Sender, Self, Context.Sender and Context.Self must be closed when accessed inside a lambda expression argument body, because it can go out of context.
@Aaronontheweb
Copy link
Member

I think we need a live code reproduction of this bug before we write an analyzer rule for it, lest we have the PipeTo problem.

@Arkatufus
Copy link
Contributor Author

The relevant repro for this edge case is here: akkadotnet/akka.net#7122

@Aaronontheweb
Copy link
Member

@Arkatufus looks legit - please proceed with writing the rules and fixes

@Arkatufus Arkatufus changed the title AK1000 Must close over Sender and Self when using ReceiveAsync and ReceiveAnyAsync AK1000 Must close over Sender and Self when accessed inside a lambda argument body Apr 1, 2024
@Arkatufus Arkatufus mentioned this issue Apr 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[AK1005] Must close sender in async lambda expression argument Arkatufus/akka.analyzers
2 participants
@Aaronontheweb @Arkatufus