Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Culture sensitive field ordering in writers/readers #186

Open
marius-klimantavicius opened this issue Oct 7, 2020 · 0 comments
Open

Culture sensitive field ordering in writers/readers #186

marius-klimantavicius opened this issue Oct 7, 2020 · 0 comments

Comments

@marius-klimantavicius
Copy link

marius-klimantavicius commented Oct 7, 2020

ReflectionEx orders fields using current culture (it simply uses OrderBy(s=>s.Name)). It is possible (as I've encountered) that two different locales would result in different fields orders.
In my case lt-LT orders y before o, so fields ToDate and Type are ordered ["Type", "ToDate"]. In en-US, o comes before y, so the fields are ordered as ["ToDate", "Type"].
Not sure how to fix that in non-breaking manner. Locally, I just added StringComparer.Ordinal.

Alternatively it could use manifest (if fields are listed) to generate correct reader.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant