Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Typescript #19

Open
akinncar opened this issue Jun 28, 2021 · 0 comments
Open

Improve Typescript #19

akinncar opened this issue Jun 28, 2021 · 0 comments
Assignees
@joojscript
Labels
enhancement New feature or request

Comments

@akinncar
Copy link
Owner

Describe the Feature

Currently, in source code on internal functions, we don't have types with typescript. We need to move types from annotations (removing any) and add all types to prevent bugs and improve the DX experience.

Possible Implementations

Refactor annotations to types, and add type check to ci.yml on pull requests.
@akinncar akinncar added the enhancement New feature or request label Jun 28, 2021
@joojscript joojscript self-assigned this Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joojscript joojscript

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@akinncar @joojscript