Feature: Add option overwrite-default #54
Merged
+79
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riting the default locale
testower
force-pushed
the
feature/opt-out-overwrite
branch
from
79b4374 to
fd67919
Compare
|
@testower nice! Please add a test. |
|
Sorry for the delay. This file does not seem to have a test already, do you have any hint to get started? |
akameco
force-pushed
the
feature/opt-out-overwrite
branch
from
c322a7a to
5c62d8f
Compare
akameco
approved these changes
Mar 24, 2020
|
@testower Thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Added cli option
--overwrite-default, which has default value true.Why:
Issue #6: If you re-reun extract-messages and output to files that have already been translated, it will overwrite existing translations for the default locale. This option provides an opt-out, so that existing translations are not overwritten.
How:
Added a cli option, which, if set to false, will handle the merging of the messages for the default locale in the same way as the merging of non-default locale messages. I.e. it will only add new keys, not overwrite existing keys.
Checklist: