Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Docker container #580

Open
jvacek opened this issue Apr 10, 2024 · 4 comments
Open

Feature Request: Docker container #580

jvacek opened this issue Apr 10, 2024 · 4 comments
Labels
CI enhancement New feature or request

Comments

@jvacek
Copy link

jvacek commented Apr 10, 2024

Is your feature request related to a problem? Please describe.
I'd like to use Darker in our ci/cd, and it would be nice if I didn't have to build the container myself for this.

Describe the solution you'd like
a published container

Describe alternatives you've considered
Building container myself

Additional context
ghcr is good enough

@akaihola akaihola added enhancement New feature or request CI labels Apr 13, 2024
@akaihola
Copy link
Owner

Thanks @jvacek for the feature request!

This is of course an obvious enhancement which would probably be useful to many.

Did you consider using the existing Darker GitHub action as an alternative?

If that doesn't work for you, and if we decide to add a container image, I think I'd prefer not to include any linters in it since linting support is anyway being moved into Graylint and deprecated in Darker. As for the reformatting tools, it probably makes sense to include all supported reformatters, which currently are:

  • Black
  • isort
  • flynt

And if we add support for e.g. pyupgrade (see #51), Ruff (#521) or Blue (#309), we should probably add all of those in the image as well.

@akaihola
Copy link
Owner

akaihola commented Apr 13, 2024

@jvacek can you think of a Python package which builds a Docker container in its GitHub actions and uploads it to GHCR, and does this in a clean way following best practices? It would be nice to be able to use that as a reference when adding this to Darker.

Edit: Maybe Black Dockerfile and .github/workflows/docker.yml, although the latter only seems to push to Docker Hub.

@jvacek
Copy link
Author

jvacek commented Apr 13, 2024

I was going to reference the black one as well, I would replicate that as closely as possible; would be nice to be "drop-in-able" on the docker front as well.

@akaihola
Copy link
Owner

"drop-in-able" on the docker front

You mean using a Darker image instead of a Black image and have it interoperate with other tooling?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants