Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace missing in fakerbot #37

Closed
akabiru opened this issue Jul 25, 2019 · 3 comments
Closed

Namespace missing in fakerbot #37

akabiru opened this issue Jul 25, 2019 · 3 comments

Comments

@akabiru
Copy link
Owner

akabiru commented Jul 25, 2019

image

Gem built from latest master. Windows 10, ruby 2.4.4p296 (2018-03-28 revision 63013) and ruby 2.5.3p105 (2018-10-18 revision 65156)

Expecting to see full namespace at top of tree, ie Faker::PhoneNumber (as shown in #1507 )

From: faker-ruby/faker#1565

@akabiru akabiru mentioned this issue Jul 25, 2019
5 tasks
@bpleslie
Copy link
Contributor

I'm unable to reproduce the issue in ruby 2.4.0 or ruby 2.5.3 on MacOS Sierra 10.12.4

brad@WM00XXX-BLeslie faker-bot (master) $ bin/faker search phone -v
Faker::PhoneNumber
├── cell_phone=> 473-608-1850
├── cell_phone_with_country_code=> +503 1-306-753-7292
├── phone_number=> 1-485-375-6716 x85706
└── phone_number_with_country_code=> +47 155-965-6795
Faker::SouthAfrica
├── cell_phone=> +2776 908 4843
└── phone_number=> +2756 245 8958
brad@WM00XXX-BLeslie faker-bot (master) $ ruby -v
ruby 2.4.0p0 (2016-12-24 revision 57164) [x86_64-darwin16]
brad@WM00XXX-BLeslie faker-bot (master) $ bin/faker search phone -v
Faker::PhoneNumber
├── cell_phone=> 546.360.4663
├── cell_phone_with_country_code=> +599 (672) 651-4366
├── phone_number=> 931.882.7159 x357
└── phone_number_with_country_code=> +269 811.373.4484 x04564
Faker::SouthAfrica
├── cell_phone=> +2781 389 2356
└── phone_number=> 046 681 4986
brad@WM00XXX-BLeslie faker-bot (master) $ ruby -v
ruby 2.5.3p105 (2018-10-18 revision 65156) [x86_64-darwin16]

Is there any chance this has been fixed since it was reported in March @akabiru? 🤔 Otherwise it may be a Windows issue..

@akabiru
Copy link
Owner Author

akabiru commented Jul 25, 2019

I think it's was reported as a Windows-specific issue, @richardbulger are you able to chime in here?

@akabiru
Copy link
Owner Author

akabiru commented Apr 21, 2020

I'm unable to reproduce the issue in ruby 2.4.0 or ruby 2.5.3 on MacOS Sierra 10.12.4

brad@WM00XXX-BLeslie faker-bot (master) $ bin/faker search phone -v
Faker::PhoneNumber
├── cell_phone=> 473-608-1850
├── cell_phone_with_country_code=> +503 1-306-753-7292
├── phone_number=> 1-485-375-6716 x85706
└── phone_number_with_country_code=> +47 155-965-6795
Faker::SouthAfrica
├── cell_phone=> +2776 908 4843
└── phone_number=> +2756 245 8958
brad@WM00XXX-BLeslie faker-bot (master) $ ruby -v
ruby 2.4.0p0 (2016-12-24 revision 57164) [x86_64-darwin16]
brad@WM00XXX-BLeslie faker-bot (master) $ bin/faker search phone -v
Faker::PhoneNumber
├── cell_phone=> 546.360.4663
├── cell_phone_with_country_code=> +599 (672) 651-4366
├── phone_number=> 931.882.7159 x357
└── phone_number_with_country_code=> +269 811.373.4484 x04564
Faker::SouthAfrica
├── cell_phone=> +2781 389 2356
└── phone_number=> 046 681 4986
brad@WM00XXX-BLeslie faker-bot (master) $ ruby -v
ruby 2.5.3p105 (2018-10-18 revision 65156) [x86_64-darwin16]

Is there any chance this has been fixed since it was reported in March @akabiru? 🤔 Otherwise it may be a Windows issue..

Resolving this issue as there have been no new reports- we can re-open if otherwise. 👍

@akabiru akabiru closed this as completed Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants