Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix broken links #2006

Merged
merged 2 commits into from Nov 13, 2022
Merged

docs: fix broken links #2006

merged 2 commits into from Nov 13, 2022

Conversation

smithc10
Copy link
Contributor

@smithc10 smithc10 commented Jun 10, 2022 •
edited

What issue does this pull request resolve?
fixing broken links in docs - #1873
What changes did you make?
changed destination paths in specified md files
Is there anything that requires more attention while reviewing?
No

@smithc10 smithc10 mentioned this pull request Jun 10, 2022
Open
@smithc10
Copy link
Contributor Author

Hi all, this is my first open source contribution (of hopefully many)! However, I'm a little stuck on why the coverage report check is failing?

I ran test-cov as specified in the repo and the output shows my changes should't have affected test coverage in any capacity. I'm not quite sure why 1 lines of markdown would result in this. Is anyone able to assist a beginner?

image

@epoberezkin
Copy link
Member

I wouldn't worry about coverage report failing, some rounding error in coveralls.

@epoberezkin epoberezkin added the OK label Nov 13, 2022
@epoberezkin epoberezkin merged commit 67e7f1c into ajv-validator:master Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epoberezkin epoberezkin Awaiting requested review from epoberezkin

Assignees
No one assigned
Labels
OK
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smithc10 @epoberezkin