fixes standalone module exports for compatibility with esm modules. #1757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odules without explicitly accessing default property. fix(lib/runtime/parseJson.ts): added `any` to error object in order to fix the type checking error.
epoberezkin
approved these changes
Sep 12, 2021
|
Thank you - it's in 8.6.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this pull request resolve?
#1754.
What changes did you make?
Changed exporting of standalone module so that esm module can import it directly without explicitly accessing default property. These changes are very similar to the one made to fix ESM module import requires using .default property #1381.
Fixed minor typescript check error
Is there anything that requires more attention while reviewing?
I have tried importing fixed
standalonemodule on both commonjs as well as esm module projects. They both work fine.