Pass baseId to getSchemaRefs to fix local $ref resolution in a schema without an id.
#1725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbuckton
force-pushed
the
refResolveBaseURI
branch
from
97b5861
to
e62c905
Compare
rbuckton
commented
Aug 1, 2021
Comment on lines
+95
to
97
| const schId = normalizeId(schema[schemaId] || baseId) | ||
| const baseIds: {[JsonPtr in string]?: string} = {"": schId} | ||
| const pathPrefix = getFullPath(schId, false) |
There was a problem hiding this comment.
Honestly, not even sure schId is necessary since baseId is already computed by Ajv.prototype._addSchema.
Suggested change
| const schId = normalizeId(schema[schemaId] || baseId) | |
| const baseIds: {[JsonPtr in string]?: string} = {"": schId} | |
| const pathPrefix = getFullPath(schId, false) | |
| const baseIds: {[JsonPtr in string]?: string} = {"": baseId} | |
| const pathPrefix = getFullPath(baseId, false) |
|
thank you - in 8.6.3 - it was an annoying one, I'm surprised the fix was so simple ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this pull request resolve?
Fixes #1711
What changes did you make?
Pass
baseIdtogetSchemaRefsso that$refcan resolve local references when the parent schema has no$id.Is there anything that requires more attention while reviewing?
No, though running
npm run test-specresults in 156 test failures without my changes, and doesn't seem to currently be wired up tonpm testin any way.