feat: expose PropertiesSchema and RequiredMembers types #1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You may be better off with having them in definitions (but you still can type-check them using these types) - I will merge it. @erikbrinkman added a very advanced type for JTDSchemaType with discriminated union support do check it out. |
This was referenced Mar 8, 2021
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this pull request resolve?
If we have a properties schema or required members that share across multiple schema then we would like to declare it separately. So, we need
PropertiesSchemaandRequiredMemberstypes to help us declare value.What changes did you make?
Export type
PropertiesSchemaand typeRequiredMembers.Is there anything that requires more attention while reviewing?
No.