Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Placeholder #5526

Open
2 tasks done
MarketingPip opened this issue Mar 30, 2024 · 3 comments
Open
2 tasks done

Improve Placeholder #5526

MarketingPip opened this issue Mar 30, 2024 · 3 comments

Comments

@MarketingPip
Copy link

Describe the feature

The placeholder should break lines automatically if printMarginColumn is enabled.

Use Case

This is a no brainier.

Proposed Solution

Split text by printMarginColumn size into array. Then populate line by line into ace.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

ACE version used

Latest

@marinsokol5
Copy link
Contributor

Hey,
But why not just provide splitted placeholder then?
It seems possible that some consumers might want to have marginColumn shown and still placeholder going out of it.

You can definitely say it's unlikely, and I would agree with you, but it's nice to not be too opinionated with libraries as it usually allows for more use case implementations.

@MarketingPip
Copy link
Author

@marinsokol5 - add a flag possibly "placeHolderMargin" with it set to default by true then 🤷‍♂️

@marinsokol5
Copy link
Contributor

Yeah that's fair, we can consider this as an Ace option 👍🏻.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants