Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gutter: "Read annotations row X" aria-label doesn't contain the type of annotation #5499

Open
avinashbot opened this issue Mar 7, 2024 · 0 comments

Comments

@avinashbot
Copy link

Describe the bug

In the gutter, when an annotation icon is present, the aria-label just states "Read annotations row X", but doesn't provide any information to assistive technology whether it's an info, warning, or error icon.

Expected Behavior

Ideally, the aria-label should be something like "Error, read annotations, row 1" or "Warning, read annotations, row 1", where the string starts with the icon type of the button being focused.

Current Behavior

When testing (with enableKeyboardAccessibility enabled), VoiceOver on Mac reads the icon as "Read annotations, row 1, button". No information about the icon itself is communicated to screen readers.

Reproduction Steps

  1. Open ace with a language that supports syntax checking (e.g. Javascript in the kitchen sink)
  2. Cause a syntax error or a warning.
  3. See that the .ace_gutter_annotation in the DOM has an aria-label without the icon type mentioned in it.

Possible Solution

No response

Additional Information/Context

Relevant lines: src/layer/gutter.js

Ace Version / Browser / OS / Keyboard layout

^1.32.6 / Any / Any / Qwerty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants