Skip to content
This repository has been archived by the owner on Sep 16, 2021. It is now read-only.

Browsersync Docker container is broken #13

Open
ajacques opened this issue Aug 13, 2015 · 1 comment
Open

Browsersync Docker container is broken #13

ajacques opened this issue Aug 13, 2015 · 1 comment

Comments

@ajacques
Copy link
Owner

The Browsersync overlay container doesn't work because the client-side JS script tries to connect to the server running on port :8080 instead of just letting it get proxied through NGINX as before. This is a recent regression on their part.
See issue: BrowserSync/browser-sync#505
Problem commit: BrowserSync/browser-sync@b2fa337

Auto refreshing from asset changes is broken from this.

ajacques added a commit that referenced this issue Aug 24, 2015
This will revert to release 2.7.12 of BrowserSync and lock it,
which does mean we miss out on some new features. We need to push
BrowserSync/browsersync@505 to get this fixed
@ajacques ajacques added bug and removed bug labels Aug 24, 2015
@ajacques
Copy link
Owner Author

ajacques commented Sep 8, 2015

The next problem is that BrowserSync forwards the request after rewriting the Host header to be equal to the --proxy parameter ('web:8080'). While this works to forward traffic to the right container, it's not the external Host that should be used. We need to figure out how to get it to pass the Host header through without modifying it. This currently breaks absolute path generation, which is used in a few places.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant