New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with Clap 4? #5
Comments
I added support for I have just uploaded 2.4 that expands the clap versions it is compatible with in the Cargo.toml to include Clap 4. You should be good with something along the lines of:
|
Thanks a lot @aj-bagwell ! We upgraded clio in PRQL/prql#1003 while keeping clap at 3. We get no messages from But upgrading to clap
Let me know if this is something we're doing wrong! |
The issue is because cargo for reasons that make no sense to me decided that clio should get clap3 and the prql-compiler should get clap4, hence while Some judicious forcing of the versions in the lock file makes it happy, (see this PR). |
😬 Thanks a lot for the PR! |
Hi there! It's me again, from #4
We're now attempting to upgrade to clap 4 (PRQL/prql#999, though dependabot will probably open a new one for a new patch release).
I'm running
cargo check --features clap/deprecated -p prql-compiler
, and seeing messages like:Does this mean it requires a
TypedValueParser
? Would this be something we should write or would it come from clio?Thank you as ever, clio has served us well (and deserves more installs!)
The text was updated successfully, but these errors were encountered: