From e65c18ee25905ca51e36b8ce3382eeda2fd67ee0 Mon Sep 17 00:00:00 2001 From: Ilya Antipenko Date: Wed, 31 Oct 2018 23:38:59 +0200 Subject: [PATCH] Remove useless mock - this mock didn't work well before because phpunit didn't mock method addDefaultDiscriminatorMap. - since phpunit 7.4.0 it throws warning in case of mocking method which is not really mocked (sebastianbergmann/phpunit#3127) --- .../Tests/ORM/Mapping/ClassMetadataFactoryTest.php | 9 --------- 1 file changed, 9 deletions(-) diff --git a/tests/Doctrine/Tests/ORM/Mapping/ClassMetadataFactoryTest.php b/tests/Doctrine/Tests/ORM/Mapping/ClassMetadataFactoryTest.php index 21774c55732..fe4af539832 100644 --- a/tests/Doctrine/Tests/ORM/Mapping/ClassMetadataFactoryTest.php +++ b/tests/Doctrine/Tests/ORM/Mapping/ClassMetadataFactoryTest.php @@ -180,15 +180,6 @@ public function testAddDefaultDiscriminatorMap() : void self::assertEquals($childDiscriminatorMap, $rootDiscriminatorMap); self::assertEquals($anotherChildDiscriminatorMap, $rootDiscriminatorMap); - - // ClassMetadataFactory::addDefaultDiscriminatorMap shouldn't be called again, because the - // discriminator map is already cached - $cmf = $this->getMockBuilder(ClassMetadataFactory::class)->setMethods(['addDefaultDiscriminatorMap'])->getMock(); - $cmf->setEntityManager($em); - $cmf->expects($this->never()) - ->method('addDefaultDiscriminatorMap'); - - $rootMetadata = $cmf->getMetadataFor(RootClass::class); } public function testGetAllMetadataWorksWithBadConnection() : void