Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix README documentation for passing args to browsers #314

Merged
merged 1 commit into from
May 6, 2021

Conversation

jzombie
Copy link
Contributor

@jzombie jzombie commented May 6, 2021

After some trial and error, figured out why I wasn't able to pass arguments to the browsers and updated the README accordingly.

@vweevers
Copy link
Member

vweevers commented May 6, 2021

Nice, thanks. Note though that the options are specific per browser provider. So airtap-playwright supports this launch option but airtap-sauce does not.

@vweevers vweevers merged commit 7f60f88 into airtap:master May 6, 2021
@vweevers
Copy link
Member

vweevers commented May 6, 2021

Oops, the readme example was actually correct.

@vweevers vweevers added this to Backlog in Airtap May 6, 2021
vweevers added a commit that referenced this pull request May 7, 2021
@vweevers
Copy link
Member

vweevers commented May 7, 2021

Reverted in cc1789d

@vweevers vweevers moved this from Backlog to Done in Airtap May 7, 2021
@jzombie
Copy link
Contributor Author

jzombie commented May 7, 2021

The PR I made was the only way to open Chrome in incognito. I've posted two screenshots comparing one another below.

airtap-incognito
airtap-not-incognito

@jzombie
Copy link
Contributor Author

jzombie commented May 7, 2021

This line of code is what passes the options, it looks like: https://github.com/airtap/the-last-browser-launcher/blob/8049d3ac7108b741a3770cb76f56dc1dba2aae9d/lib/launch/index.js#L146.

Either https://github.com/airtap/the-last-browser-launcher needs a PR to fix the API, or the documentation needs to be updated here, I think.

@vweevers
Copy link
Member

vweevers commented May 7, 2021

The example in the readme here is for airtap-playwright, not airtap-system.

@jzombie
Copy link
Contributor Author

jzombie commented May 7, 2021

Whoops! I do apologize about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Airtap
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants