Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow setting hostAliases in Pods #548

Open
2 of 4 tasks
F43RY opened this issue Mar 23, 2022 · 3 comments
Open
2 of 4 tasks

allow setting hostAliases in Pods #548

F43RY opened this issue Mar 23, 2022 · 3 comments
Labels
kind/enhancement kind - new features or changes status/needs-discussion status - this needs discussion

Comments

@F43RY
Copy link

F43RY commented Mar 23, 2022

Checks

Motivation

Hi,
I'd like to set hostAlias in containers like git-sync in order to fetch dags from on premises scm but at the moment this is not possible with current velues.yaml.

Implementation

As workaround I edited the deployed deployments to include hostAliases in manifest. The best way should be to add hostAlias in values.yaml for each container.

Are you willing & able to help?

  • I am able to submit a PR!
  • I can help test the feature!
@F43RY F43RY added the kind/enhancement kind - new features or changes label Mar 23, 2022
@thesuperzapper
Copy link
Member

@F43RY can you clarify why you need to set hostAliases to be able to "fetch dags from on premises scm"?

Do your on-premise servers not exist in your cluster's DNS?

@thesuperzapper thesuperzapper changed the title HostAliases in Containers allow setting hostAliases in Pods Mar 23, 2022
@F43RY
Copy link
Author

F43RY commented Mar 23, 2022

exactly

@thesuperzapper
Copy link
Member

@F43RY I would strongly recommend creating a split-horizon DNS for your company and using this as the DNS for your Kubernetes cluster.

That is, forward the DNS queries for internal domains like internal.example.org to your on-prem DNS resolver, and forward public domains like google.com to an internet DNS resolver like 1.1.1.1.


Generally speaking, this chart tries to avoid supporting extremely user-specific features, or features that represent anti-patterns in airflow or Kubernetes.

I personally believe using hostAliases represents both an "extremely user-specific feature" and an "anti-pattern for Kubernetes".

I will leave the issue open so that others can voice their support if they also need this feature.

@thesuperzapper thesuperzapper added the lifecycle/frozen lifecycle - this can't become stale label Mar 23, 2022
@thesuperzapper thesuperzapper added status/needs-discussion status - this needs discussion and removed lifecycle/frozen lifecycle - this can't become stale labels Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement kind - new features or changes status/needs-discussion status - this needs discussion
Projects
Issue Triage and PR Tracking
Triage | Needs Discussion
Development

No branches or pull requests

2 participants