Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: sample app doesn't handle correct direction of text, in "Animated text" #707

Closed
AndroidDeveloperLB opened this issue Mar 26, 2018 · 6 comments

Comments

@AndroidDeveloperLB
Copy link

I get this when writing in Hebrew :

image

@gpeal
Copy link
Collaborator

gpeal commented Mar 27, 2018

Lotte doesn't support RTL. Text support is pretty basic for now and it may be quite a while before RTL is supported unless someone does a PR for it

@gpeal gpeal added the Text label Mar 27, 2018
@AndroidDeveloperLB
Copy link
Author

@gpeal Can you please set it as a feature request then?

@ArthurVimond
Copy link
Contributor

@gpeal Hi! I'm currently working on this feature, and I have a few questions:

1- Should we detect the direction for each TextLayer input and draw them independently or just getting the device current language setting and apply the same direction for all texts?

2- Regarding the text justification, drawing RTL texts with Justification.LEFT_ALIGN should start from the right (not from the left), right? Also, should we refactor the Justification enums as START_ALIGN, CENTER, END_ALIGN (like layout margin / padding system)?

Thanks.

@AndroidDeveloperLB
Copy link
Author

@ArthurVimond What you wrote doesn't belong here... Please make a new thread about it.

@gpeal
Copy link
Collaborator

gpeal commented Aug 11, 2019

Duplicate of #1145

@gpeal gpeal marked this as a duplicate of #1145 Aug 11, 2019
@gpeal gpeal closed this as completed Aug 11, 2019
@AndroidDeveloperLB
Copy link
Author

Ummm.... Why mark a request from "Mar 26, 2018" as duplicate of one from "Mar 6" of this year (2019) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants