Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IDFilter support for ChatJoinRequest events #983

Merged
merged 1 commit into from Aug 29, 2022
Merged

Add IDFilter support for ChatJoinRequest events #983

merged 1 commit into from Aug 29, 2022

Conversation

nsychev
Copy link

@nsychev nsychev commented Aug 17, 2022

Description

In current version adding chat_id filter to chat_join_request_handler leads to never-executing-handler.

This PR fixes such behavior.

Type of change

  • New feature (non-breaking change that adds functionality)

How has this been tested?

dispatcher.register_chat_join_request_handler(
    self.join_request,
    chat_id=self.config["bot"]["chat_id"]
)

Before PR: it didn't handle any updates. After PR: it handles updates from given chat.

(sorry, I don't think I'll able to write some tests in the near future)

Test Configuration

  • Operating system: NixOS 22.05
  • Python version: 3.10.1

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works as expected
  • New and existing unit tests pass locally with my changes
  • My changes generate no new warnings or errors
  • My changes are compatible with minimum requirements of the project
  • I have made corresponding changes to the documentation

@github-actions github-actions bot added the 2.x Issue or PR for legacy 2.x version label Aug 17, 2022
@evgfilim1 evgfilim1 added bug Something is wrong with the framework enhancement Make it better! labels Aug 19, 2022
@evgfilim1 evgfilim1 self-requested a review August 19, 2022 17:57
@JrooTJunior JrooTJunior merged commit 87a8b50 into aiogram:dev-2.x Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Issue or PR for legacy 2.x version bug Something is wrong with the framework enhancement Make it better!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants