New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
command filter now can be sets with BotCommand object #935
Merged
JrooTJunior
merged 8 commits into
aiogram:dev-2.x
from
bomzheg:dev-2.x-command-filter-with-commands
Aug 13, 2022
Merged
command filter now can be sets with BotCommand object #935
JrooTJunior
merged 8 commits into
aiogram:dev-2.x
from
bomzheg:dev-2.x-command-filter-with-commands
Aug 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ogether with plain strings
Lamroy95
reviewed
Jun 24, 2022
evgfilim1
added
enhancement
Make it better!
new feature
Missing feature
2.x
Issue or PR for stable 2.x version
labels
Jun 25, 2022
evgfilim1
suggested changes
Jun 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See @Lamroy95's comment
@bomzheg have you tested this directly? Can you provide a code which you run to test? |
JrooTJunior
requested changes
Jul 7, 2022
bomzheg
force-pushed
the
dev-2.x-command-filter-with-commands
branch
from
July 8, 2022 12:24
8bff951
to
2dffa0e
Compare
evgfilim1
suggested changes
Jul 12, 2022
bomzheg
force-pushed
the
dev-2.x-command-filter-with-commands
branch
from
July 12, 2022 11:07
fe3d237
to
9b83aa3
Compare
evgfilim1
suggested changes
Jul 12, 2022
evgfilim1
approved these changes
Jul 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your effort.
JrooTJunior
approved these changes
Aug 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2.x
Issue or PR for stable 2.x version
enhancement
Make it better!
new feature
Missing feature
waiting for reply
Further information is requested
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
it will be usefull for bots using SetMyCommands api call.
Example:
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist:
Few tests are not pass. Probably problem is in windows ( https://t.me/aiogram_ru/1176021 )