Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filtering skip_patterns #868

Merged
merged 2 commits into from Aug 13, 2022
Merged

Fix filtering skip_patterns #868

merged 2 commits into from Aug 13, 2022

Conversation

Tishka17
Copy link
Contributor

@Tishka17 Tishka17 commented Mar 23, 2022

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples or any documentation update)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Operating System:
  • Python version:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@JrooTJunior JrooTJunior added the enhancement Make it better! label Mar 26, 2022
@JrooTJunior JrooTJunior added this to the 2.19.1 milestone Mar 26, 2022
@JrooTJunior
Copy link
Member

@Tishka17, any news?

@evgfilim1 evgfilim1 added the 2.x Issue or PR for legacy 2.x version label May 12, 2022
@evgfilim1 evgfilim1 modified the milestones: 2.21, 2.x next Jul 3, 2022
@Tishka17 Tishka17 marked this pull request as ready for review July 30, 2022 10:49
@JrooTJunior JrooTJunior merged commit d565406 into aiogram:dev-2.x Aug 13, 2022
Copy link
Contributor

@gabbhack gabbhack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NameError: name 'item' is not defined

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Issue or PR for legacy 2.x version enhancement Make it better!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants