Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from aioredis to redis.asyncio #1074

Merged
merged 2 commits into from Dec 4, 2022
Merged

Migrate from aioredis to redis.asyncio #1074

merged 2 commits into from Dec 4, 2022

Conversation

Olegt0rr
Copy link
Contributor

@Olegt0rr Olegt0rr commented Dec 1, 2022 •
edited

Description

Fix #862

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

Tests successfully passed

Screenshot 2022-12-01 at 17 24 27

Test Configuration

  • Operating system: MacOS
  • Python version: 3.9

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works as expected
  • New and existing unit tests pass locally with my changes
  • My changes generate no new warnings or errors
  • My changes are compatible with minimum requirements of the project
  • I have made corresponding changes to the documentation

@Olegt0rr Olegt0rr added the 2.x Issue or PR for stable 2.x version label Dec 1, 2022
@Olegt0rr Olegt0rr self-assigned this Dec 1, 2022
@Olegt0rr Olegt0rr requested a review from a team December 1, 2022 14:28
@JrooTJunior JrooTJunior merged commit ae53429 into dev-2.x Dec 4, 2022
taimast added a commit to taimast/aiogram that referenced this pull request Dec 22, 2022
@taimast
Revert "Migrate from aioredis to redis.asyncio (aiogram#1074)"
51f4cf5 
This reverts commit ae53429.
mykolasolodukha added a commit to mykolasolodukha/vilnyypay_bot that referenced this pull request Feb 6, 2023
@mykolasolodukha
👽 Install redis dependency instead of aioredis
5f4d6ad 
Reference: aiogram/aiogram#1074
@JrooTJunior JrooTJunior deleted the new-redis-py branch February 12, 2023 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JrooTJunior JrooTJunior JrooTJunior approved these changes

Assignees

@Olegt0rr Olegt0rr

Labels
2.x Issue or PR for stable 2.x version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[2.x] Add redis-py built-in asyncio support
2 participants
@Olegt0rr @JrooTJunior