Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add field can_manage_video_chats to ChatMemberOwner #1003

Merged
merged 4 commits into from Sep 24, 2022
Merged

Add field can_manage_video_chats to ChatMemberOwner #1003

merged 4 commits into from Sep 24, 2022

Conversation

andrew000
Copy link
Contributor

@andrew000 andrew000 commented Sep 17, 2022 •
edited

Description

Add field can_manage_video_chats to ChatMemberOwner

  • New feature (non-breaking change that adds functionality)

How has this been tested?

No tests, just add field

Test Configuration

  • Operating system: Win10
  • Python version: 3.9.*

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works as expected
  • New and existing unit tests pass locally with my changes
  • My changes generate no new warnings or errors
  • My changes are compatible with minimum requirements of the project
  • I have made corresponding changes to the documentation

@github-actions github-actions bot added the 2.x Issue or PR for legacy 2.x version label Sep 17, 2022
@evgfilim1 evgfilim1 added the enhancement Make it better! label Sep 17, 2022
@evgfilim1
Copy link
Contributor

evgfilim1 commented Sep 17, 2022 •
edited

I think it must be renamed with deprecation

image
https://core.telegram.org/bots/api#april-16-2022

@andrew000
Copy link
Contributor Author

TESTS:
image

@Olegt0rr
Copy link
Contributor

TESTS: image

this should be issue for tests

@Olegt0rr Olegt0rr mentioned this pull request Sep 20, 2022
Closed
@andrew000
Copy link
Contributor Author

TESTS: image

this should be issue for tests

Since all the tests are passed, is it possible to merge PR?

@JrooTJunior JrooTJunior merged commit 4e78ce1 into aiogram:dev-2.x Sep 24, 2022
@andrew000 andrew000 deleted the new_fields_chat_member_owner branch October 2, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Olegt0rr Olegt0rr Olegt0rr approved these changes

Assignees
No one assigned
Labels
2.x Issue or PR for legacy 2.x version enhancement Make it better!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andrew000 @evgfilim1 @Olegt0rr @JrooTJunior