Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified caching in Github actions configuration. #694

Merged
merged 1 commit into from Mar 29, 2022

Conversation

felixxm
Copy link
Contributor

@felixxm felixxm commented Mar 21, 2022

What do these changes do?

This bumps checkout and setup-python versions in the GitHub actions configuration to v3 and simplifies dependency caching.

Are there changes in behavior for the user?

No.

Related issue number

No.

Checklist

  • I think the code is well written
  • (no needed) Unit tests for the changes exist
  • (no needed) Documentation reflects the changes
  • (no needed) Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: Fix issue with non-ascii contents in doctest text files.

@felixxm felixxm changed the title Bump checkout/setup-python versions in GitHub actions configuration… Bump checkout/setup-python versions in GitHub actions configuration to v3. Mar 21, 2022
@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #694 (6bf9350) into master (ff9f159) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #694   +/-   ##
=======================================
  Coverage   99.73%   99.73%           
=======================================
  Files           4        4           
  Lines         750      750           
  Branches      170      170           
=======================================
  Hits          748      748           
  Misses          2        2           
Flag Coverage Δ
unit 99.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff9f159...6bf9350. Read the comment docs.

@felixxm
Copy link
Contributor Author

felixxm commented Mar 28, 2022

I rebased from the master branch.

@felixxm felixxm changed the title Bump checkout/setup-python versions in GitHub actions configuration to v3. Bumped checkout versions in Github actions configuration to v3 and simplified caching. Mar 28, 2022
@felixxm
Copy link
Contributor Author

felixxm commented Mar 28, 2022

Rebased again.

@felixxm felixxm changed the title Bumped checkout versions in Github actions configuration to v3 and simplified caching. Simplified caching in Github actions configuration. Mar 28, 2022
@mjpieters
Copy link
Contributor

Hi 👋!

Thank you 🙏 for improving the workflows here! I agree this is a good change, so I tried to rebase it and add a CHANGES entry, but I don’t think you ticked the “allow updates from the maintainers” checkbox on the PR so I can’t do so here.

Could you please rebase one more time and add a CHANGES/694.misc.rst file please?

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Mar 29, 2022
@mjpieters mjpieters enabled auto-merge (squash) March 29, 2022 00:23
@mjpieters
Copy link
Contributor

Never mind, the permissions issue was entirely down to my own gh command line token needing an update.

This will be merged as soon as the checks complete!

@mjpieters mjpieters merged commit 1a43a04 into aio-libs:master Mar 29, 2022
@felixxm
Copy link
Contributor Author

felixxm commented Mar 29, 2022

Thanks for merging 👍

@felixxm felixxm deleted the checkout-setup-python-v3 branch March 29, 2022 04:06
q0w pushed a commit to q0w/yarl that referenced this pull request Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants