Use METH_FASTCALL where it makes sense #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
Codecov Report
@@ Coverage Diff @@
## master #681 +/- ##
=======================================
Coverage 93.65% 93.65%
=======================================
Files 5 5
Lines 504 504
=======================================
Hits 472 472
Misses 32 32 Continue to review full report at Codecov.
|
webknjaz
added a commit
to webknjaz/multidict
that referenced
this pull request
Jan 5, 2024
This reverts commit 3da0f79.
webknjaz
added a commit
to webknjaz/multidict
that referenced
this pull request
Jan 16, 2024
This reverts commit 3da0f79.
webknjaz
added a commit
to webknjaz/multidict
that referenced
this pull request
Jan 16, 2024
This reverts commit 3da0f79.
webknjaz
added a commit
to webknjaz/multidict
that referenced
this pull request
Jan 16, 2024
This reverts commit 3da0f79. Partially, at least. Under Python 3.13+ only.
webknjaz
added a commit
to webknjaz/multidict
that referenced
this pull request
Jan 16, 2024
This reverts commit 3da0f79. Partially, at least. Under Python 3.13+ only.
webknjaz
added a commit
to webknjaz/multidict
that referenced
this pull request
Jan 16, 2024
This reverts commit 3da0f79. Partially, at least. Under Python 3.13+ only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the change,
MultiDict.add()is 2.2 times faster thanMETH_VARARGS | METH_KEYWORDSversion.CIMultiDictshows not such an exciting boost, it is only 1.5 times faster. Not bad anyway.