Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'Dictionary changed during iteration' exception raising #628

Merged
merged 3 commits into from
Sep 30, 2021

Conversation

asvetlov
Copy link
Member

Don't raise 'Dictionary changed during iteration' when the error should not be thrown

Fix #620

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Sep 30, 2021
@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

Merging #628 (e3b146f) into master (9dde0bd) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #628      +/-   ##
==========================================
- Coverage   93.78%   93.77%   -0.02%     
==========================================
  Files           5        5              
  Lines         499      498       -1     
==========================================
- Hits          468      467       -1     
  Misses         31       31              
Flag Coverage Δ
unit 93.77% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
multidict/_multidict_py.py 99.40% <100.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dde0bd...e3b146f. Read the comment docs.

@asvetlov asvetlov merged commit 0cd7837 into master Sep 30, 2021
@asvetlov asvetlov deleted the add_pypy_test branch September 30, 2021 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

potential pypy mutability bug
3 participants