Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

janus: remove unused type ignores #287

Merged
merged 1 commit into from Oct 10, 2020
Merged

Conversation

hauntsaninja
Copy link
Contributor

The unused type ignores cause make mypy to fail on master (using the mypy version specified in requirements-dev.txt)

The unused type ignores cause `make mypy` to fail when run on master (using the mypy version specified in requirements-dev.txt).
@codecov
Copy link

codecov bot commented Oct 4, 2020

Codecov Report

Merging #287 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #287   +/-   ##
=======================================
  Coverage   99.67%   99.67%           
=======================================
  Files           1        1           
  Lines         309      309           
  Branches       41       41           
=======================================
  Hits          308      308           
  Partials        1        1           
Impacted Files Coverage Δ
janus/__init__.py 99.67% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30091ce...e7b9e66. Read the comment docs.

Copy link
Member

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asvetlov asvetlov merged commit ac23eb7 into aio-libs:master Oct 10, 2020
@asvetlov
Copy link
Member

Thanks!

@hauntsaninja hauntsaninja deleted the patch-1 branch October 10, 2020 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants