Skip to content

The 'timeout' arg should be typed as (optional) float instead of int #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
moloney opened this issue Jun 23, 2020 · 1 comment
Closed

The 'timeout' arg should be typed as (optional) float instead of int #267

moloney opened this issue Jun 23, 2020 · 1 comment

Comments

@moloney
Copy link

moloney commented Jun 23, 2020

The sync queue proxy has the timeout arg typed as an optional int, but to match the stdlib queue it should be an optional float.
@asvetlov
Copy link
Member

asvetlov commented Aug 4, 2020

Makes sense.
Would you prepare a pull request?

@asvetlov asvetlov mentioned this issue Oct 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asvetlov @moloney