Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental 3.11 tests #292

Merged
merged 2 commits into from Aug 2, 2022
Merged

Add experimental 3.11 tests #292

merged 2 commits into from Aug 2, 2022

Conversation

Dreamsorcerer
Copy link
Member

No description provided.

@Dreamsorcerer
Copy link
Member Author

Well, that's weird. pytest just fails with no output...

@aio-libs aio-libs deleted a comment from codecov bot Apr 23, 2022
@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #292 (bc53ddd) into master (9caf8bc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #292   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files           1        1           
  Lines          61       61           
  Branches        7       10    +3     
=======================================
  Hits           60       60           
  Misses          1        1           
Flag Coverage Δ
unit 96.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us.

@cclauss
Copy link
Contributor

cclauss commented Jul 19, 2022

Will Python 3.11-beta.4 pass if the cython==0.29.30 upgrade is made in the file requirements/ci.txt?

@Dreamsorcerer
Copy link
Member Author

I'll try it out later, when I've got time. But, feel free to branch off and get it working before me.

@cclauss
Copy link
Contributor

cclauss commented Jul 19, 2022

The GitHub Actions on my PRs (like #306, #307, and #308) do not run until approved by a repo maintainer.

@Dreamsorcerer
Copy link
Member Author

Approved them.

@cclauss
Copy link
Contributor

cclauss commented Aug 2, 2022

Upgrading all dependencies in requirements/ci.txt allows the GitHub Action tests to pass on Python 3.11.

@cclauss
Copy link
Contributor

cclauss commented Aug 2, 2022

The failing test is being run on pytest==6.2.5, not the current version. https://pypi.org/project/pytest

Upgrading all dependencies in requirements/ci.txt should make all GitHub Actions green.

@Dreamsorcerer
Copy link
Member Author

OK, dependabot needs to be fixed for this project. It's only updating things in the github workflow, not Python requirements files..

@Dreamsorcerer Dreamsorcerer enabled auto-merge (squash) August 2, 2022 17:45
@Dreamsorcerer Dreamsorcerer merged commit 6d00df1 into master Aug 2, 2022
@Dreamsorcerer Dreamsorcerer deleted the Dreamsorcerer-patch-1 branch August 2, 2022 17:47
@webknjaz
Copy link
Member

webknjaz commented Aug 2, 2022

OK, dependabot needs to be fixed for this project. It's only updating things in the github workflow, not Python requirements files..

Yeah, I noticed that but couldn't figure out why that's happening, looking at the config. Does it need to be pointed at a different folder?

include:
- os: ubuntu
pyver: "3.11.0-alpha - 3.11.0"
experimental: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, if it passes, maybe we don't need "experimental" anymore? The first release candidate is just a week away, after all...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm inclined to just leave an experimental version in, so it can just be bumped to 3.12 a little later.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too late 15b0085

@Dreamsorcerer
Copy link
Member Author

Yeah, I noticed that but couldn't figure out why that's happening, looking at the config. Does it need to be pointed at a different folder?

It appears to be the same in aiohttp, so no idea why it's not activating here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants