Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop attrs and use dataclass instead #341

Open
pepoluan opened this issue Dec 22, 2022 · 2 comments
Open

Drop attrs and use dataclass instead #341

pepoluan opened this issue Dec 22, 2022 · 2 comments
Labels
tech-debt Things that needs to be tidied up to avoid being bitten in the future...

Comments

@pepoluan
Copy link
Collaborator

Another thought occurred to me: As we've dropped Python 3.6 support, we can also use dataclass rather than attrs.

This will reduce aiosmtpd's dependency for sure.

@pepoluan pepoluan added the tech-debt Things that needs to be tidied up to avoid being bitten in the future... label Dec 22, 2022
@pepoluan
Copy link
Collaborator Author

I have found that attrs's kw_only field specifier is widely used, and dataclass didn't begin to have the same feature until 3.10

So... keep this dep for now?

@waynew
Copy link
Collaborator

waynew commented Jan 2, 2023

That's probably fair enough. I don't actually even know attrs or dataclass that well, unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt Things that needs to be tidied up to avoid being bitten in the future...
Projects
None yet
Development

No branches or pull requests

2 participants