Skip to content
This repository has been archived by the owner on Feb 21, 2023. It is now read-only.

Fix duplicate calls to pool.wait_closed() upon create_pool() exception #671

Conversation

achimnol
Copy link
Contributor

What do these changes do?

Just a minor fix to remove a duplicate function call I have found while I'm reading the code.

Are there changes in behavior for the user?

There should be nothing.
This code path is only taken when there are exceptions while creating a new Redis pool, which would rarely happen in normal use cases.

If this is an intended duplication, I think the authors should add a comment describing why.

Related issue number

This is just a simple one-liner PR. 馃槈

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example:
      Fix issue with non-ascii contents in doctest text files.

@codecov
Copy link

codecov bot commented Nov 29, 2019

Codecov Report

Merging #671 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #671   +/-   ##
=======================================
  Coverage   97.06%   97.06%           
=======================================
  Files          57       57           
  Lines        8114     8114           
  Branches      568      568           
=======================================
  Hits         7876     7876           
  Misses        172      172           
  Partials       66       66

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 52345bc...68490a8. Read the comment docs.

@popravich
Copy link
Contributor

Please add a news fragment.

@popravich popravich changed the base branch from master to fix_671 December 2, 2019 08:51
@popravich popravich merged commit 58195ac into aio-libs-abandoned:fix_671 Dec 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants