Skip to content
This repository has been archived by the owner on Feb 21, 2023. It is now read-only.

Fix LGTM.com alerts #646

Merged
merged 2 commits into from Oct 1, 2019
Merged

Fix LGTM.com alerts #646

merged 2 commits into from Oct 1, 2019

Conversation

popravich
Copy link
Contributor

@popravich popravich commented Sep 30, 2019

What do these changes do?

Fix LGTM.com alerts https://lgtm.com/projects/g/aio-libs/aioredis/alerts/?mode=list

Are there changes in behavior for the user?

no

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Add a new news fragment into the CHANGES/ folder

@lgtm-com
Copy link

lgtm-com bot commented Sep 30, 2019

This pull request fixes 8 alerts when merging 3cba4dd into bac9b42 - view on LGTM.com

fixed alerts:

  • 4 for Unnecessary 'else' clause in loop
  • 2 for Module is imported with 'import' and 'import from'
  • 1 for Unused local variable
  • 1 for Mismatch between signature and use of an overridden method

@codecov
Copy link

codecov bot commented Sep 30, 2019

Codecov Report

Merging #646 into master will increase coverage by 0.48%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #646      +/-   ##
==========================================
+ Coverage   96.85%   97.34%   +0.48%     
==========================================
  Files          57       57              
  Lines        8551     9102     +551     
  Branches      578      640      +62     
==========================================
+ Hits         8282     8860     +578     
+ Misses        192      170      -22     
+ Partials       77       72       -5
Impacted Files Coverage Δ
aioredis/sentinel/pool.py 81.27% <100%> (+4.49%) ⬆️
aioredis/abc.py 100% <100%> (ø) ⬆️
aioredis/locks.py 95.83% <100%> (-0.17%) ⬇️
tests/stream_commands_test.py 100% <0%> (ø) ⬆️
tests/server_commands_test.py 100% <0%> (ø) ⬆️
tests/sentinel_commands_test.py 100% <0%> (ø) ⬆️
tests/generic_commands_test.py 100% <0%> (ø) ⬆️
tests/pool_test.py 99.77% <0%> (+0.04%) ⬆️
tests/pubsub_receiver_test.py 99.67% <0%> (+0.81%) ⬆️
tests/_testutils.py 85.48% <0%> (+1.27%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bac9b42...3cba4dd. Read the comment docs.

@popravich popravich merged commit f080f01 into master Oct 1, 2019
@popravich popravich deleted the lgtm_fixes branch October 1, 2019 14:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant