Skip to content
This repository has been archived by the owner on Feb 21, 2023. It is now read-only.

Implementation of the BZPOPMAX/BZPOPMIN commands and additional options of ZADD. #618

Merged
merged 5 commits into from Jul 15, 2019

Conversation

otykhonruk
Copy link
Contributor

@otykhonruk otykhonruk commented Jul 8, 2019

What do these changes do?

Implementation of the blocking pop commands for the sorted set: BZPOPMAX and BZPOPMIN.
Implementation of the the CH and INCR options of the ZADD command.

Are there changes in behavior for the user?

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example:
      Fix issue with non-ascii contents in doctest text files.

@codecov
Copy link

codecov bot commented Jul 8, 2019

Codecov Report

Merging #618 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #618      +/-   ##
==========================================
- Coverage   96.85%   96.85%   -0.01%     
==========================================
  Files          57       57              
  Lines        8482     8540      +58     
  Branches      571      578       +7     
==========================================
+ Hits         8215     8271      +56     
- Misses        191      192       +1     
- Partials       76       77       +1
Impacted Files Coverage Δ
aioredis/commands/sorted_set.py 100% <100%> (ø) ⬆️
tests/sorted_set_commands_test.py 100% <100%> (ø) ⬆️
tests/_testutils.py 84.21% <0%> (-3.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbc6689...209bb0e. Read the comment docs.

@popravich
Copy link
Contributor

Please fulfill last two points of checklist

@popravich popravich self-assigned this Jul 9, 2019
@popravich popravich self-requested a review July 9, 2019 13:37
@popravich popravich removed their assignment Jul 9, 2019
@otykhonruk
Copy link
Contributor Author

Please fulfill last two points of checklist

@popravich Done.

@popravich popravich merged commit dc04acc into aio-libs-abandoned:master Jul 15, 2019
@popravich
Copy link
Contributor

Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants