This repository has been archived by the owner on Feb 21, 2023. It is now read-only.
Type Hints for aioredis #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ enabling type hints using `mypy` + added initial type checks for `errors.py` and `parser.py`
webknjaz
reviewed
Apr 20, 2019
| - &MYPY | ||
| name: mypy | ||
| cache: false | ||
| python: "3.6" |
There was a problem hiding this comment.
Suggested change
| python: "3.6" | |
| python: "3.7" |
There was a problem hiding this comment.
Makes total sense. Added 3.7 version for Travis-CI job.
popravich
suggested changes
Apr 20, 2019
aioredis/parser.py
Outdated
| self.pos: int = 0 | ||
| self.protocolError: Callable = protocolError | ||
| self.replyError: Callable = replyError | ||
| self.encoding: Optional[str] = encoding |
There was a problem hiding this comment.
This wont work in Python 3.5
There was a problem hiding this comment.
I mean variable annotations
Ensuring that typings will be recognized by python 3.5
Codecov Report
@@ Coverage Diff @@
## master #584 +/- ##
===========================================
- Coverage 96.82% 80.34% -16.49%
===========================================
Files 57 57
Lines 8411 7976 -435
Branches 563 561 -2
===========================================
- Hits 8144 6408 -1736
- Misses 191 1513 +1322
+ Partials 76 55 -21
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
mypyerrors.pyandparser.pyAre there changes in behavior for the user?
None
Related issue number
#555
Checklist
CONTRIBUTORS.txt<Name> <Surname>.CHANGESfolder<issue_id>.<type>(e.g.588.bugfix)issue_idchange it to the pr id after creating the PR.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.