Skip to content
This repository has been archived by the owner on Feb 21, 2023. It is now read-only.

add a count to spop #485

Merged
merged 2 commits into from Nov 2, 2018
Merged

Conversation

KostSvitlana
Copy link
Contributor

resolved issue #411

@codecov
Copy link

codecov bot commented Oct 31, 2018

Codecov Report

Merging #485 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #485      +/-   ##
==========================================
+ Coverage   96.79%   96.85%   +0.06%     
==========================================
  Files          56       56              
  Lines        7871     7894      +23     
  Branches      552      553       +1     
==========================================
+ Hits         7619     7646      +27     
+ Misses        181      180       -1     
+ Partials       71       68       -3
Impacted Files Coverage Δ
aioredis/commands/set.py 100% <100%> (ø) ⬆️
tests/set_commands_test.py 100% <100%> (ø) ⬆️
aioredis/sentinel/pool.py 81.57% <0%> (+1.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1cd04c...b3d2497. Read the comment docs.

tests/set_commands_test.py Show resolved Hide resolved
aioredis/commands/set.py Outdated Show resolved Hide resolved
@popravich
Copy link
Contributor

Thanks for contribution, please fix the above issues and I'll merge it.

@KostSvitlana
Copy link
Contributor Author

Thanks for your help

@popravich popravich merged commit 10ac4cb into aio-libs-abandoned:master Nov 2, 2018
@popravich
Copy link
Contributor

Thanks

@bukowa
Copy link

bukowa commented Dec 7, 2018

Hello! Thanks @KostSvitlana!

Question: when i install the package via pip this commit is not visible, aioredis version == 1.2.0

@KostSvitlana
Copy link
Contributor Author

Hello! Thanks @KostSvitlana!

Question: when i install the package via pip this commit is not visible, aioredis version == 1.2.0

It's because this changes will be in next release

@Natim
Copy link

Natim commented Apr 29, 2019

Hello, I was going to reopen this issue because I reach this bug, is it possible to release it?

Current fallback:

await redis_client.execute("SPOP", key, REQUEST_SIZE)

@popravich popravich added this to the 1.3 milestone Sep 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants