Skip to content
This repository has been archived by the owner on Feb 21, 2023. It is now read-only.

redis stream support #438

Closed
bsergean opened this issue Aug 11, 2018 · 8 comments
Closed

redis stream support #438

bsergean opened this issue Aug 11, 2018 · 8 comments
Labels
resolved-via-latest This indicates this issue is either resolved or invalid as of the latest version.

Comments

@bsergean
Copy link

Hi there, here are a bunch of questions around redis streams.

  1. What is the plan for supporting redis stream? Wait until the feature is out of beta and redis 5 is released?
  2. Should it be implemented like pubsub, or more like a normal set of commands.
  3. Also I guess that it has to be supported in hiredis first ?
  4. Would it be possible to try to implement it outside of redis stream in my own project, using monkey patching or something similar, until the support is really here (as is, how extensible aioredis is). That could be a bad idea?

Thanks for any thoughts !

@barrachri
Copy link

#299 is already inside master.

@barrachri
Copy link

barrachri commented Aug 12, 2018

Something that (I think) is missing is using xread with async for

messages = redis.xread(['test_stream'])

async for message in messages:
    pass

I guess we can use something like this:

https://github.com/aio-libs/aioredis/blob/ea948d0d7047db3315b4fbb9aa66e9ccc7e41522/aioredis/pubsub.py#L134

cc @adamcharnock

@adamcharnock
Copy link
Collaborator

Hey @barrachri, I think this would be a good feature. I don't have time to look into it right now, but I'd be happy to look over any pull request if you wish (although I have no authority to merge).

@barrachri
Copy link

Ok, thanks @adamcharnock!

@barrachri
Copy link

#472

@f0ff886f
Copy link

Some commands are still missing (XDEL) and (XTRIM), is it possible to get them in as well?

@ivarec
Copy link

ivarec commented Dec 29, 2018

Is this the main issue to track the development of XDEL and friends?

@curiouscod3 curiouscod3 mentioned this issue Jun 13, 2019
5 tasks
@curiouscod3
Copy link
Contributor

curiouscod3 commented Jun 13, 2019

@adamcharnock @ivarec @bsergean
I've added xdel and xtrim. Still needs some test in real world. Please try it.
It worked in my dev environment.

@seandstewart seandstewart added the resolved-via-latest This indicates this issue is either resolved or invalid as of the latest version. label Mar 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
resolved-via-latest This indicates this issue is either resolved or invalid as of the latest version.
Projects
None yet
Development

No branches or pull requests

7 participants