Skip to content
This repository has been archived by the owner on Feb 21, 2023. It is now read-only.

Bump the version for 2.0.0 release #1075

Merged
merged 5 commits into from Jul 30, 2021
Merged

Bump the version for 2.0.0 release #1075

merged 5 commits into from Jul 30, 2021

Conversation

abrookins
Copy link
Contributor

@abrookins abrookins commented Jul 29, 2021

What do these changes do?

Bumps the version to 2.0.0 in prep for tagging the release.

Fixes #1031

Are there changes in behavior for the user?

An unqualified pip install aioredis will now install version 2.0.0. This version is not backwards compatible with earlier versions of aioredis. Instead, it aims to port the redis-py API to asyncio.

Related issue number

#930

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example:
      Fix issue with non-ascii contents in doctest text files.

@codecov
Copy link

codecov bot commented Jul 29, 2021

Codecov Report

Merging #1075 (eb9bd17) into master (b2952d9) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1075      +/-   ##
==========================================
- Coverage   89.19%   89.16%   -0.03%     
==========================================
  Files          21       21              
  Lines        6823     6823              
  Branches      653      653              
==========================================
- Hits         6086     6084       -2     
- Misses        567      569       +2     
  Partials      170      170              
Flag Coverage Δ
unit 89.13% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aioredis/__init__.py 83.33% <100.00%> (-16.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2952d9...eb9bd17. Read the comment docs.

Copy link
Collaborator

@Andrew-Chen-Wang Andrew-Chen-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to address #1040 first

@Andrew-Chen-Wang
Copy link
Collaborator

@abrookins L25 in setup.py needs to be changed

Copy link
Collaborator

@Andrew-Chen-Wang Andrew-Chen-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if a fix for #1040 will be breaking in anyone's production, but we'll see. (Edit: in retrospect, if it doesn't work, it won't break anything since it just won't work.)

LGTM!!!

@abrookins
Copy link
Contributor Author

Hi, may I ask Why don't you plan to support python3.6 ?

We'll add that back. I removed it while trying to fix #1040, but the attempt was unsuccessful. Also, we should be able to maintain compatibility either way.

@abrookins abrookins merged commit 6612ba7 into master Jul 30, 2021
@abrookins abrookins deleted the release-2.0 branch July 30, 2021 06:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2.0] Update setup.py Trove classifiers
4 participants