Skip to content
This repository has been archived by the owner on Feb 21, 2023. It is now read-only.

Rename the health check #1074

Merged
merged 1 commit into from Jul 29, 2021
Merged

Rename the health check #1074

merged 1 commit into from Jul 29, 2021

Conversation

abrookins
Copy link
Contributor

@abrookins abrookins commented Jul 29, 2021

What do these changes do?

Rename the health check, so we aren't also using "redis-py-healthcheck."

Fixes #1065

Are there changes in behavior for the user?

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example:
      Fix issue with non-ascii contents in doctest text files.

@codecov
Copy link

codecov bot commented Jul 29, 2021

Codecov Report

Merging #1074 (ec33b7f) into master (6b5355d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1074   +/-   ##
=======================================
  Coverage   89.18%   89.18%           
=======================================
  Files          21       21           
  Lines        6816     6816           
  Branches      653      653           
=======================================
  Hits         6079     6079           
  Misses        570      570           
  Partials      167      167           
Flag Coverage Δ
unit 89.15% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aioredis/client.py 82.31% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b5355d...ec33b7f. Read the comment docs.

@abrookins abrookins merged commit ff37ce6 into master Jul 29, 2021
@abrookins abrookins deleted the fix-health-check branch July 29, 2021 16:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename redis-py health check message
3 participants