Skip to content
This repository has been archived by the owner on Feb 21, 2023. It is now read-only.

Add _lock to BlockingConnectionPool #1068

Merged
merged 4 commits into from Jul 29, 2021
Merged

Add _lock to BlockingConnectionPool #1068

merged 4 commits into from Jul 29, 2021

Conversation

abrookins
Copy link
Contributor

What do these changes do?

Fixes #1047.

Are there changes in behavior for the user?

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder
    • name it <issue_id>.<type> (e.g. 588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the PR
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example:
      Fix issue with non-ascii contents in doctest text files.

@codecov
Copy link

codecov bot commented Jul 24, 2021

Codecov Report

Merging #1068 (3e9d710) into master (f9b0590) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1068      +/-   ##
==========================================
+ Coverage   89.18%   89.19%   +0.01%     
==========================================
  Files          21       21              
  Lines        6816     6823       +7     
  Branches      653      653              
==========================================
+ Hits         6079     6086       +7     
+ Misses        570      567       -3     
- Partials      167      170       +3     
Flag Coverage Δ
unit 89.16% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aioredis/connection.py 66.01% <100.00%> (+0.24%) ⬆️
tests/test_connection_pool.py 99.30% <100.00%> (+0.01%) ⬆️
aioredis/client.py 82.20% <0.00%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9b0590...3e9d710. Read the comment docs.

@abrookins abrookins marked this pull request as ready for review July 29, 2021 13:24
Copy link
Collaborator

@Andrew-Chen-Wang Andrew-Chen-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

CHANGES/1068.bugfix Outdated Show resolved Hide resolved
Co-authored-by: Andrew Chen Wang <60190294+Andrew-Chen-Wang@users.noreply.github.com>
@abrookins abrookins merged commit b2952d9 into master Jul 29, 2021
@abrookins abrookins deleted the missing-lock branch July 29, 2021 18:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BlockingConnectionPool exception on disconnect
2 participants