Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aiodns can probably be enabled on windows, now that it ships with c-ares already built #8121

Open
1 task done
JinEnMok opened this issue Jan 31, 2024 · 3 comments
Open
1 task done

Comments

@JinEnMok
Copy link

Is your feature request related to a problem?

The aiodns library from the [speedup] bundle is currently disabled on Windows per this line .

However, aiodns currently ships with pycares, which bundles a binary of c-ares by default. I was just now able to install it on Win10 with pip.

Describe the solution you'd like

It seems there's no need to exclude Windows from the aiodns speedup. Looks like changing https://github.com/aio-libs/aiohttp/blob/master/setup.cfg#L64 would be sufficient, but I'm by no means experienced, so I'd rather not mess with the repo myself.

Describe alternatives you've considered

There seems to be some requests to get rid of aiodns entirely in favour of pydns, but maybe till then we can use it like this?

Related component

Client

Additional context

No response

Code of Conduct

  • I agree to follow the aio-libs Code of Conduct
@webknjaz
Copy link
Member

webknjaz commented Feb 1, 2024

You can still use it, the dependency helper (speedups extra) doesn't influence anything short of what's pulled in on install. If it's present in the env, it'll be used.

@JinEnMok
Copy link
Author

JinEnMok commented Feb 1, 2024

Should be an easy fix then, especially if it's strongly recommended for performance reason.

@webknjaz
Copy link
Member

webknjaz commented Feb 1, 2024

You could make a PR to see how our CI likes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants