Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ada url parser #7217

Closed
v1gnesh opened this issue Feb 20, 2023 · 2 comments
Closed

Use ada url parser #7217

v1gnesh opened this issue Feb 20, 2023 · 2 comments

Comments

@v1gnesh
Copy link

v1gnesh commented Feb 20, 2023

Firstly, thank you to everyone who has contributed to this project over the years.
The impact your contributions have on others' productivity & work in general is invaluable.

In continuation of the work done in #1626, #5364, and #6144... I wanted to ask if ada could be used for URL parsing.

Nodejs will be integrating it shortly - nodejs/node#46410 & nodejs/node@3ee97ee.

@Dreamsorcerer
Copy link
Member

Well, if it offers a benefit, and someone wants to add it, then seems reasonable.

I'm not sure exactly where the URL parsing happens, but I suspect it's through yarl, so the change will need to happen in that project, rather than aiohttp.

@v1gnesh
Copy link
Author

v1gnesh commented Feb 21, 2023

Thanks Sam, I know nothing about C/C++ 😬 .
Just thought I'd surface this here in case anyone is interested.
I'll "move" this issue to yarl, and close this one for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants