Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove chardet from documentation and extra dependencies #6236

Closed
1 task done
asvetlov opened this issue Nov 3, 2021 · 0 comments
Closed
1 task done

Remove chardet from documentation and extra dependencies #6236

asvetlov opened this issue Nov 3, 2021 · 0 comments
Labels
bug good first issue Good for newcomers

Comments

@asvetlov
Copy link
Member

asvetlov commented Nov 3, 2021

Describe the bug

Grepping over the source code shows that chardet/cchardet is still present in codebase, but chardet was replaced with charset-normalizer by #5930

A hero for dropping all remaining parts is wanted!

:)

To Reproduce

grep over aiohttp cloned repo; or use github web search: https://github.com/aio-libs/aiohttp/search?q=chardet&type=code

Expected behavior

No chardet/cchardet in repo anymore

Logs/tracebacks

---

Python Version

all

aiohttp Version

master, 3.8, 3.9

multidict Version

---

yarl Version

---

OS


Related component

Server, Client

Additional context

The issue is easy

Code of Conduct

  • I agree to follow the aio-libs Code of Conduct
@asvetlov asvetlov added bug good first issue Good for newcomers labels Nov 3, 2021
@asvetlov asvetlov changed the title Remove chardet/cchardet from documentation and extra dependencies Remove chardet from documentation and extra dependencies Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant