We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃悶 Describe the bug
Tests break when proxy environment variables (HTTP_PROXY, HTTPS_PROXY, etc.) are set.
馃挕 To Reproduce
export http_proxy='http://www.example.com,http://proxy.com' make test
馃挕 Expected behavior
Tests should pass.
馃搵 Logs/tracebacks
FAILED tests/test_helpers.py::test_proxies_from_env[https] - AssertionError: assert dict_keys(['http', 'https']) == {'https'} FAILED tests/test_helpers.py::test_proxies_from_env[ws] - AssertionError: assert dict_keys(['http', 'ws']) == {'ws'} FAILED tests/test_helpers.py::test_proxies_from_env[wss] - AssertionError: assert dict_keys(['http', 'wss']) == {'wss'} FAILED tests/test_helpers.py::test_proxies_from_env_skipped[https] - AssertionError: assert {'http': ProxyInfo(proxy=URL('http://www.example.com,http//proxy.com'), proxy_auth=None)} == {} FAILED tests/test_helpers.py::test_proxies_from_env_skipped[wss] - AssertionError: assert {'http': ProxyInfo(proxy=URL('http://www.example.com,http//proxy.com'), proxy_auth=None)} == {}
馃搵 Your version of the Python
$ python --version Python 3.8.7
馃搵 Your version of the aiohttp/yarl/multidict distributions
$ python -m pip show aiohttp Name: aiohttp Version: 4.0.0a1 Summary: Async http client/server framework (asyncio) Home-page: https://github.com/aio-libs/aiohttp Author: Nikolay Kim Author-email: fafhrd91@gmail.com License: Apache 2 Location: /Users/cirelli/Projects/aiohttp Requires: chardet, multidict, async-timeout, yarl, typing-extensions, frozenlist, aiosignal Required-by:
$ python -m pip show multidict Name: multidict Version: 5.1.0 Summary: multidict implementation Home-page: https://github.com/aio-libs/multidict Author: Andrew Svetlov Author-email: andrew.svetlov@gmail.com License: Apache 2 Location: /Users/cirelli/Projects/aiohttp/.venv/lib/python3.8/site-packages Requires: Required-by: yarl, aiohttp
$ python -m pip show yarl Name: yarl Version: 1.6.3 Summary: Yet another URL library Home-page: https://github.com/aio-libs/yarl/ Author: Andrew Svetlov Author-email: andrew.svetlov@gmail.com License: Apache 2 Location: /Users/cirelli/Projects/aiohttp/.venv/lib/python3.8/site-packages Requires: idna, multidict Required-by: aiohttp
馃搵 Additional context
Mac OS
The text was updated successfully, but these errors were encountered:
That's unfortunate... Mind submitting a PR?
Sorry, something went wrong.
Sure, I mentioned it in my last PR that I'd create a new one to fix it. I figured it required a new PR.
Ah, I somehow missed that.. Thanks!
Implemented by #5557 and #6184.
scirelli
No branches or pull requests
馃悶 Describe the bug
Tests break when proxy environment variables (HTTP_PROXY, HTTPS_PROXY, etc.) are set.
馃挕 To Reproduce
馃挕 Expected behavior
Tests should pass.
馃搵 Logs/tracebacks
馃搵 Your version of the Python
馃搵 Your version of the aiohttp/yarl/multidict distributions
馃搵 Additional context
Mac OS
The text was updated successfully, but these errors were encountered: