Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make type hints for http parser stricter #5267

Merged
merged 2 commits into from Nov 22, 2020
Merged

Make type hints for http parser stricter #5267

merged 2 commits into from Nov 22, 2020

Conversation

asvetlov
Copy link
Member

@asvetlov asvetlov commented Nov 22, 2020

A part of work on #5220

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Nov 22, 2020
@codecov
Copy link

codecov bot commented Nov 22, 2020

Codecov Report

Merging #5267 (13968f7) into master (bb53507) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5267      +/-   ##
==========================================
+ Coverage   97.52%   97.54%   +0.02%     
==========================================
  Files          43       43              
  Lines        8803     8806       +3     
  Branches     1415     1415              
==========================================
+ Hits         8585     8590       +5     
+ Misses        103      101       -2     
  Partials      115      115              
Flag Coverage Δ
unit 97.37% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiohttp/client_exceptions.py 98.33% <100.00%> (+0.01%) ⬆️
aiohttp/client_proto.py 96.66% <100.00%> (ø)
aiohttp/http_parser.py 97.14% <100.00%> (+0.45%) ⬆️
aiohttp/web_protocol.py 92.28% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb53507...13968f7. Read the comment docs.

@asvetlov asvetlov merged commit a6c7f15 into master Nov 22, 2020
@asvetlov asvetlov deleted the parser-typing branch November 22, 2020 11:42
@aio-libs-github-bot
Copy link
Contributor

💔 Backport was not successful

The PR was attempted backported to the following branches:

  • ❌ 3.8: Commit could not be cherrypicked due to conflicts

asvetlov added a commit that referenced this pull request Nov 22, 2020
(cherry picked from commit a6c7f15)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
asvetlov added a commit that referenced this pull request Nov 22, 2020
(cherry picked from commit a6c7f15)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
commonism pushed a commit to commonism/aiohttp that referenced this pull request Apr 27, 2021
commonism pushed a commit to commonism/aiohttp that referenced this pull request Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant