Skip to content

Update docs to say aiohttp doesn't support HTTPS proxies #4100

Closed
@bbkane

Description

@bbkane
Contributor

Long story short

The docs say aiohttp supports HTTPS proxies, but the library raises an exception on HTTPS proxies, and there is issue to add support for them.

Expected behaviour

The docs shouldn't say HTTPS proxies are supported.

Actual behaviour

The docs say HTTPS proxies are supported.

Activity

asvetlov

asvetlov commented on Sep 25, 2019

@asvetlov
Member

It doesn't support proxies that require https:// for connection to.
But proxy that can be connected by http:// with upgrade to HTTPS by CONNECT HTTP method is supported.

bbkane

bbkane commented on Sep 25, 2019

@bbkane
ContributorAuthor

YES THATS WORKING!!! Please do update the docs to specify that though.

asvetlov

asvetlov commented on Sep 25, 2019

@asvetlov
Member

Would you prepare a pull request?
I believe now you can rephrase the text to avoid any misunderstanding.

bbkane

bbkane commented on Sep 25, 2019

@bbkane
ContributorAuthor
bbkane

bbkane commented on Sep 26, 2019

@bbkane
ContributorAuthor

Created #4101

added a commit that references this issue on Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      Participants

      @asvetlov@bbkane

      Issue actions

        Update docs to say `aiohttp` doesn't support HTTPS proxies · Issue #4100 · aio-libs/aiohttp