Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement StreamReader.readuntil() method #4054

Closed
yapith-suplari opened this issue Sep 10, 2019 · 4 comments
Closed

Implement StreamReader.readuntil() method #4054

yapith-suplari opened this issue Sep 10, 2019 · 4 comments

Comments

@yapith-suplari
Copy link

yapith-suplari commented Sep 10, 2019

Long story short:
Should be mimic to asyncio.StreamReader counterpart: https://docs.python.org/3/library/asyncio-stream.html#asyncio.StreamReader.readuntil

(Re-opening #1151)

This solution is great to have in the toolbox dealing with pulling high-load data from servers that don't declare their response content-length. Currently I run into partial content.read() intermittently under high-load situations e.g. (#3881).

@asvetlov
Copy link
Member

You can master something with content.readany() already without waiting for a new aiohttp version.

WisdomPill added a commit to WisdomPill/aiohttp that referenced this issue May 11, 2020
@abeeeshek
Copy link

something i am currently dealing with, @asvetlov can you review the PR #4734 @WisdomPill, i can pitch in for the remaining task.

@WisdomPill
Copy link
Member

What is the remaining task?

WisdomPill added a commit to WisdomPill/aiohttp that referenced this issue Nov 1, 2020
@asvetlov
Copy link
Member

asvetlov commented Nov 2, 2020

Fixed by #4734

@asvetlov asvetlov closed this as completed Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants