Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable implicit switch-back to pure python mode. #3828

Merged
merged 6 commits into from Jun 8, 2019

Conversation

asvetlov
Copy link
Member

@asvetlov asvetlov commented Jun 8, 2019

The build fails loudly if aiohttp cannot be compiled with C Accellerators.
Use AIOHTTP_NO_EXTENSIONS=1 to explicitly disable C Extensions complication and switch to Pure-Python mode.
Note that Pure-Python mode is significantly slower than compiled one.

The build fails loudly if aiohttp cannot be compiled with C Accellerators.
Use AIOHTTP_NO_EXTENSIONS=1 to explicitly disable C Extensions complication and switch to Pure-Python mode.
Note that Pure-Python mode is significantly slower than compiled one.
@asvetlov asvetlov requested a review from webknjaz as a code owner June 8, 2019 09:16
@asvetlov
Copy link
Member Author

asvetlov commented Jun 8, 2019

Should apply the same to multidict and yarl eventually.

@asvetlov asvetlov merged commit 5684c43 into master Jun 8, 2019
@asvetlov asvetlov deleted the strict-compile-mode branch June 8, 2019 11:59
@SomberNight
Copy link

Is there any chance this could be backported to the 3.7.x branch?
I have a project where performance is not critical and I would like to explicitly opt out of C extensions but the only released versions of aiohttp that already have this PR are the 4.0.0 alphas. :(

multidict and yarl already have an equivalent released :)

@SomberNight
Copy link

btw part of the reason I would not like to build the extensions is to make a binary of the larger project reproducible.
As aiohttp 3.7.x uses distutils to build the extension, I would need to use at least python 3.9 (to have python/cpython@0d30ae1) to make the aiohttp C extensions reproducible.

aiohttp master no longer uses distutils (since #4079) but that has not been released either :(

@webknjaz
Copy link
Member

webknjaz commented May 2, 2021

I don't think so, it seems like a major change. Also, the 3.7 release stream doesn't get updates, all the new things are supposed to go into the 3.8 now.

@SomberNight
Copy link

SomberNight commented May 2, 2021

sure, 3.8.x would be great too, I just meant any branch that gets releases in the not-too-far future :)

@webknjaz
Copy link
Member

webknjaz commented May 2, 2021

I'm not sure sure that switching this behavior in a minor release is such a good idea.

asvetlov added a commit that referenced this pull request Oct 29, 2021
* Disable implicit switch-back to pure python mode.

The build fails loudly if aiohttp cannot be compiled with C Accellerators.
Use AIOHTTP_NO_EXTENSIONS=1 to explicitly disable C Extensions complication and switch to Pure-Python mode.
Note that Pure-Python mode is significantly slower than compiled one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants