From 51d4e3e614da252fe3b2fef0e341f415243e64c6 Mon Sep 17 00:00:00 2001 From: Dmitry Erlikh Date: Wed, 27 Oct 2021 08:50:48 +0200 Subject: [PATCH] adjust according to PR comments --- tests/test_client_session.py | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/tests/test_client_session.py b/tests/test_client_session.py index 83ed5205d8e..22596031992 100644 --- a/tests/test_client_session.py +++ b/tests/test_client_session.py @@ -709,7 +709,7 @@ async def test_requote_redirect_url_default_disable() -> None: @pytest.mark.parametrize( - "base_url,url", + ("base_url", "url"), [ (None, "http://example.com/test"), ("http://example.com", "/test"), @@ -718,20 +718,20 @@ async def test_requote_redirect_url_default_disable() -> None: (URL("http://example.com/"), "/test"), ], ) -async def test_build_url(base_url, url) -> None: - session = ClientSession(base_url) +async def test_build_url(create_session, base_url, url) -> None: + session = await create_session(base_url) assert session._build_url(url) == URL("http://example.com/test") -async def test_build_url_raises() -> None: - session = ClientSession("http://example.com") - with pytest.raises(ValueError): +async def test_build_url_raises(create_session) -> None: + session = await create_session("http://example.com") + with pytest.raises(ValueError, match="url must start with /"): session._build_url("test") -async def test_request_uses_base_url_when_url_is_str() -> None: +async def test_request_uses_base_url_when_url_is_str(create_session) -> None: request_class = mock.MagicMock() - session = ClientSession("http://example.com", request_class=request_class) + session = await create_session("http://example.com", request_class=request_class) with contextlib.suppress(Exception): await session.get("/test") @@ -740,9 +740,9 @@ async def test_request_uses_base_url_when_url_is_str() -> None: assert url == URL("http://example.com/test") -async def test_request_not_uses_base_url_when_url_is_URL() -> None: +async def test_request_not_uses_base_url_when_url_is_URL(create_session) -> None: request_class = mock.MagicMock() - session = ClientSession("http://example.com", request_class=request_class) + session = await create_session("http://example.com", request_class=request_class) with contextlib.suppress(Exception): await session.get(URL("http://sample.com"))